Zhenghan Zhou

Results 96 comments of Zhenghan Zhou

I think my change is simple but as the CI is broken, I cannot see any build problem now.

Yes. I am working on this. I found another option: add `crd:generateEmbeddedObjectMeta=true` in Makefile to generate Metadata properties.

> I think this is on the right track, but I would like us to try to reduce the code duplication a bit ideally. > > I created a sample...

@wozniakjan Could you help to review it again?

Using events can also be a good choice.

/run-e2e **Update:** You can check the progress [here](https://github.com/kedacore/keda/actions/runs/9279490925)

/run-e2e **Update:** You can check the progress [here](https://github.com/kedacore/keda/actions/runs/9279529081)

/run-e2e solr **Update:** You can check the progress [here](https://github.com/kedacore/keda/actions/runs/9280901602)

/run-e2e solr **Update:** You can check the progress [here](https://github.com/kedacore/keda/actions/runs/9377086960)

> @SpiritZhou is this still WIP or can we merge this PR? we can merge it now. Thanks!