Zhenghan Zhou

Results 96 comments of Zhenghan Zhou

Refactor internal components

This is a good improvement that makes the structure and responsibilities cleaner. I just have a few detailed questions: 1. Do the ScaledJob controller and ScaledObject controller each have a...

Emit metric tracking empty responses from prometheus

I see there are other upstream error responses from this scaler. Is an empty response enough for tracking purposes?

improve: hashicorp token management

/run-e2e hashicorp_vault **Update:** You can check the progress [here](https://github.com/kedacore/keda/actions/runs/17147295825)

Unable to fetch metrics from Prometheus Metrics Server: unable to get external metric

Is the svc of keda-metrics-apiserver working?

ScaledObject invalid due metadata.labels must be no more than 63 characters

Agree with @wozniakjan , generating a hash from name may create a new behavior for users, which could be another "breaking change". XD

Delay period for initial scaler creation

I think that keeping checking notifications is better than just relying on the waiting log, and it's a good idea to set a timeout during initialization. For example, ``` waiting...