Zhenghan Zhou

Results 96 comments of Zhenghan Zhou

Currently, the validation in webhook compares the scaleTargetRef.Name directly from two ScaledObjects instead of listing the scaling target first. Adding a field-selector in scaleTargetRef is not effective. Maybe supporting a...

@JorTurFer Could you provide more details or some specific scenario regarding the security concern? One of the scenario is that a ScaledObject in namespace A could use a label selector...

> I can start a DDoS attack, adding an attacker pod per victim pod. I can do brute force attacks for receiving information about the pods in the cluster, for...

eventEmitter.Emit() will emit a k8s event at the same time. Replacing the recorder with eventEmitter and r.Recorder.Event() with eventEmitter.Emit() is better than passing an eventEmitter as a new parameter. Alternatively,...

Hi @zroubalik, the git_commit metrics are not match in the testing. Is it possible that there is a merge operation during running the e2e test? 49b0fd0e is the next commit...

The CRD spec of scaleobject has added JSONPath to show all triggers. But kubectl still does not support displaying array type of printcolumn. https://github.com/kubernetes-sigs/controller-tools/issues/652

@tomkerkhove @JorTurFer In 2.11, the triggerauth object will be updated with an "" value when setting Finalizer in `EnsureAuthenticationResourceFinalizer`. I think the better way is to check if identityId is...

> I thought of a slightly different alternative (there would be no need for the operator to update the value to nil) > > 1. Keep the validation only in...

Which scaler do you use? I think set the para queueLength on queue scaler can shorten the time.