keda icon indicating copy to clipboard operation
keda copied to clipboard

Refactor solr scaler config

Open SpiritZhou opened this issue 1 year ago • 6 comments

WIP - Refactor Apache Kafka scaler config using declarative parser from https://github.com/kedacore/keda/pull/5676

Checklist

  • [X] I have verified that my change is according to the deprecations & breaking changes policy
  • [X] Tests have been added
  • [ ] Changelog has been updated and is aligned with our changelog requirements
  • [ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • [ ] A PR is opened to update the documentation on (repo) (if applicable)
  • [X] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to https://github.com/kedacore/keda/issues/5797

SpiritZhou avatar May 21 '24 08:05 SpiritZhou

/run-e2e Update: You can check the progress here

SpiritZhou avatar May 29 '24 02:05 SpiritZhou

/run-e2e Update: You can check the progress here

SpiritZhou avatar May 29 '24 02:05 SpiritZhou

/run-e2e solr Update: You can check the progress here

SpiritZhou avatar May 29 '24 05:05 SpiritZhou

/run-e2e solr Update: You can check the progress here

SpiritZhou avatar Jun 05 '24 02:06 SpiritZhou

/run-e2e solr Update: You can check the progress here

zroubalik avatar Jun 24 '24 09:06 zroubalik

@SpiritZhou is this still WIP or can we merge this PR?

we can merge it now. Thanks!

SpiritZhou avatar Jun 26 '24 02:06 SpiritZhou

@SpiritZhou I think you may need to check items in the checklist in order for this to merge. Not sure if the WhiteSource is ignored or the PR should be rebased? @zroubalik

wozniakjan avatar Jul 18 '24 12:07 wozniakjan

@SpiritZhou I think you may need to check items in the checklist in order for this to merge. Not sure if the WhiteSource is ignored or the PR should be rebased? @zroubalik

Hi @wozniakjan, what do you mean by WhiteSource?

SpiritZhou avatar Jul 22 '24 02:07 SpiritZhou

/run-e2e solr Update: You can check the progress here

SpiritZhou avatar Jul 22 '24 02:07 SpiritZhou

Hi @wozniakjan, what do you mean by WhiteSource?

never mind, it was a failing CI job that is no longer triggered/required I think

wozniakjan avatar Jul 22 '24 07:07 wozniakjan