keda icon indicating copy to clipboard operation
keda copied to clipboard

chore: Adds CoudEvents when a ScaledObject scales a workload from/to zero or one

Open neelanjan00 opened this issue 3 months ago • 9 comments

Checklist

  • [x] When introducing a new scaler, I agree with the scaling governance policy
  • [x] I have verified that my change is according to the deprecations & breaking changes policy
  • [x] Tests have been added
  • [x] Changelog has been updated and is aligned with our changelog requirements
  • [x] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • [x] A PR is opened to update the documentation on (repo) (if applicable)
  • [x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to #3527

neelanjan00 avatar Mar 27 '24 17:03 neelanjan00

Can you open a PR for our docs as well please?

tomkerkhove avatar Mar 29 '24 07:03 tomkerkhove

@neelanjan00 any update on this please?

zroubalik avatar Apr 10 '24 17:04 zroubalik

eventEmitter.Emit() will emit a k8s event at the same time. Replacing the recorder with eventEmitter and r.Recorder.Event() with eventEmitter.Emit() is better than passing an eventEmitter as a new parameter. Alternatively, we could pass an eventEmitter as a new parameter and delete the recorder once all r.Recorder.Event() calls have been replaced.

SpiritZhou avatar Apr 12 '24 09:04 SpiritZhou

We are planning release on Thursday, any chance we can incorporate the feedback?

tomkerkhove avatar Apr 16 '24 05:04 tomkerkhove

Hey @tomkerkhove, @zroubalik sorry for not being active on this! I am presently occupied with some office work so not able to put time away for this, not sure if I will be able to add the E2E tests on time for the release.

neelanjan00 avatar Apr 16 '24 07:04 neelanjan00

No worries!

tomkerkhove avatar Apr 24 '24 05:04 tomkerkhove