Smaptastic
Smaptastic
Using `;first-aid first aid` seems to break it for me, but that's not a big deal since the default targets the First Aid skill so it's kinda a redundant argument....
> This one I don't understand. If FC is your hometown, you can already override that with `force_repair_town` What's this toggle adding that doesn't exist today? Thanks! fang_cove_override_town toggles the...
> What is the advantage to using fang cove as your hometown? Availability from anywhere. No need to change safe rooms when moving to a new hunting zone/town. Public crafting...
> might need updates in: mining-buddy forestry-buddy herb-stock restock I don't use those so I didn't add them in, but I'm happy to do so. I'll try to get the...
> line 65: > > ```ruby > @hometown_data = get_data('town')[settings.hometown] > ``` > > Could present a problem. I THINK that only kicks in if force_repair_town and fang_cove_override_town are blank....
If that’s the case, force_repair_town never worked as advertised, since all I’m doing here is adding another variable with the exact same function. In practice, it gets currency and works...
That seems like one way to do it, sure. It's more similar to the way other scripts did it. But I don't know enough about this stuff to make significant...
I think maybe removing the town settings (engineering: Crossing, etc.) in base.yaml would be best so people who don't use this in their setup yaml don't end up running all...
Ah shoot. Was looking for the hashtag after the section (engineering: # Crossing), not before. My bad.
> The PR itself looks fine at first glance. > > Could you please show a test sample, and add the Athletics base.yaml changes to this PR? > > Thanks!...