dr-scripts icon indicating copy to clipboard operation
dr-scripts copied to clipboard

[script][first-aid] - Allow training granularity for FA/Scholarship/Both

Open asechrest opened this issue 2 years ago • 1 comments

Adds args to allow you to focus on first aid, scholarship, or both. Also adds settings to base-help.yaml.

Defaults to checking First Aid skill if none is specified, to retain prior behavior.

asechrest avatar Sep 04 '22 18:09 asechrest

As a side note, the attunement script has an arg for scholarship too:

{
          name: 'sigil',
          regex: /sigil/,
          optional: true,
          description: 'Do sigil walking (scholarship training) instead of regular attunement walking'
        }

Dartellum avatar Sep 04 '22 20:09 Dartellum

Using ;first-aid first aid seems to break it for me, but that's not a big deal since the default targets the First Aid skill so it's kinda a redundant argument. Works fine for me with default, scholarship, and both.

Smaptastic avatar Oct 20 '22 13:10 Smaptastic

Thanks for testing, and I know why. Having a script argument with a space, and without enclosing quotes, will cause the script to think the second word is an additional argument. Since this script only has one argument, it fusses at you because it thinks you have two. Will work on a fix.

asechrest avatar Oct 20 '22 18:10 asechrest

The change looks good. There wasn't a need for first aid as a setting, given that it's default. Works perfectly for both and scholarship. Ship it.

Smaptastic avatar Nov 28 '22 05:11 Smaptastic