[script][athletics] Fang Cove fix - athletics

[Smaptastic]

Athletics did not work properly with Fang Cove as hometown. Added fang_cove_override_town as a multi-script town override, and athletics_town as an athletics-specific town override.

[MahtraDR]

The PR itself looks fine at first glance.

Could you please show a test sample, and add the Athletics base.yaml changes to this PR?

Thanks!

[Smaptastic]

The PR itself looks fine at first glance.

Could you please show a test sample, and add the Athletics base.yaml changes to this PR?

Thanks!

The only base.yaml change are the variables from PR #6029. They are consistent for all of the requests I'm submitting. Happy to add them, but it'll get pretty duplicative.

[Dartellum]

Where does Fang Cove come into play with this change? I do not see elsif @athletics_location == 'Fang Cove' in the locations for the target room to train in.

[Smaptastic]

That’s because this change does the opposite of that! All of these scripts either don’t work if your hometown is Fang Cove or they take individual settings, some of which are not top level.

These fixes provide a single variable to cause all of these scripts to run out of another town, as well as individual top-level override variables for the scripts that did not already have them. They do not cause the scripts to work by performing their actions in Fang Cove. They cause the scripts to work with Fang Cove as a hometown by directing them to another town.