dr-scripts icon indicating copy to clipboard operation
dr-scripts copied to clipboard

[script][workorders] Crafting hometown override part 2

Open Raykyn55 opened this issue 2 years ago • 4 comments

Lets try this again. Problem with the original was craft method wasn't transferred for tailoring.

Additionally, some pieces of a different PR crept in.

Raykyn55 avatar Aug 20 '22 00:08 Raykyn55

I think maybe removing the town settings (engineering: Crossing, etc.) in base.yaml would be best so people who don't use this in their setup yaml don't end up running all over the world to craft. Assuming I understand properly how that works.

Edit: I don't mean removing them, sorry. Just leaving them blank rather than having a town pre-set.

Smaptastic avatar Aug 20 '22 16:08 Smaptastic

I think maybe removing the town settings (engineering: Crossing, etc.) in base.yaml would be best so people who don't use this in their setup yaml don't end up running all over the world to craft. Assuming I understand properly how that works.

Edit: I don't mean removing them, sorry. Just leaving them blank rather than having a town pre-set.

Theyre commented out in base, so inoperable by default. But that is how that would play out if they didnt set it themselves.

Raykyn55 avatar Aug 20 '22 17:08 Raykyn55

Ah shoot. Was looking for the hashtag after the section (engineering: # Crossing), not before. My bad.

Smaptastic avatar Aug 20 '22 18:08 Smaptastic

Ah shoot. Was looking for the hashtag after the section (engineering: # Crossing), not before. My bad.

np, more eyes is always better on this stuff, even if it's a whiff.

Raykyn55 avatar Aug 21 '22 02:08 Raykyn55