Sjors Provoost
Sjors Provoost
You can't know by looking at the code which configuration @sipa - or anyone else running that code - is using. And keeping track of all permutations gets quite noisy....
ACK d5e28457a099cd546e757984043f28ba9f6689b1 modulo fixup squash
I think (2) is fine. We already sign the release build, and anyone who can compile from source can run the extra `codesign` command (maybe as part of `make deploy`?)....
Should we just add a release note about this issue? IIUC it's a regression in our move to cmake, but I suspect that anyone who actually wants to use `-O3`...
What is the input `k` in `_sender_create_output_pubkey`? I find the label stuff fairly confusing, both in the BIP and in the description here. But no concrete suggestion on how to...
@MorningLightMountain713 when you built from source, did you do (more than) this? Delete lines with MAN from `Makefile.bsd` ``` ./configure --ipv6 --firewall=pf make make install ``` See also https://cgit.freebsd.org/ports/tree/net/miniupnpd/Makefile
The error "execve failed: Not a directory (20)" is quite strange, since we're not expecting `-signer` to point to a directory. Most of the action happens here: https://github.com/bitcoin/bitcoin/blame/master/src/common/run_command.cpp And the...
Yes, the real HWI is at https://github.com/bitcoin-core/HWI No need to connect an actual hardware wallet to it. > replacing fake.py by ./fake.py fixes the test for both my system and...
Seems reasonable. I'll run with 80489ba6e8430177db5c1d0c9148e83e410bd704 for a while.