Sjors Provoost

@pinheadmz of the three attack scenarios in the paper, 1.3 is prevented because we ignore unsolicited blocks with less work than the tip (see [p2p_unrequested_blocks.py](https://github.com/bitcoin/bitcoin/blob/master/test/functional/p2p_unrequested_blocks.py#L22-L24)). The paper also points this...

> But the paper states there is an implementation for Bcoin […] What do we know of how these implementations work in practice? Found the Bcoin client implementation, with the...

@sipa [here's a log](https://gist.github.com/Sjors/f56645f1109f53b007f00c1586dd1f3c) when I tried your rebased branch on mainnet. Just as it reached 90% synced headers with one of the peers, it started with another peer, quickly...

Aside from the bug, what triggers the transition to another peer? It definitely wasn't a timeout.

The pre-sync phase looks like this: I don't think it's critical to translate. As long as something is making progress, I suspect most new users will be happy :-)

The `LocatorEntries` helper function in 5ea6f9a34bf3e8751fbca8f6107e99a9f553e31f was introduced in this push: https://github.com/bitcoin/bitcoin/pull/25717#event-7174395344. It looks correct to me, but what was the motivation for adding it? I guess we were using...

> it's a bit cleaner I think Agree in the context it's used here. > It doesn't hurt though Locators are used in various places. I'm not sure how to...

re-tACK 3add23454624c4c79c9eebc060b6fbed4e3131a7 Same caveats https://github.com/bitcoin/bitcoin/pull/25717#pullrequestreview-1085263210 Agree that merging the new log into NET makes sense. In fact it's useful to look at both of them, e.g. to see that `sendheaders`...

Very cool! It's nice to be able to test this concept with "real" demo software. I'll share some thoughts about the concept on the mailinglist or gist. Will focus on...

Concept ACK `ReplaceAll()` is currently used for handling `-blocknotify`, `-walletnotify`,`-alertnotify` and escaping slashes in `-torpassword`.