Sjors Provoost comments

Results 1483 comments of


                                            Sjors Provoost

policy: make pathological transactions packed with legacy sigops non-standard

re-ACK 65b7deda12338b17f342c1d37f44e7c6da850771 ([more future](https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2177518858), [less signing](https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2175236097))

policy: make pathological transactions packed with legacy sigops non-standard

re-ACK 2c2acb37ecdeed1582b9835f9075d44e313d787c

test: add mocked Sock that can read/write custom data and/or CNetMessages

This seems very useful. I'll try to use it for the (currently very brittle) `Sv2Transport` tests in #29432, and review it along the way.

test: add mocked Sock that can read/write custom data and/or CNetMessages

@vasild thanks! At first glance these changes make sense, not sure why it's broken. I left some comments on your commit [f0dc62f8ab773ef7cbf44ba7119d08af66506428](https://github.com/vasild/bitcoin/commit/f0dc62f8ab773ef7cbf44ba7119d08af66506428).

test: add mocked Sock that can read/write custom data and/or CNetMessages

So the `Sv2Connman` is called, but `start()` isn't, so the mock `BindListenPort` doesn't happen. --- The last commit here gets all the way through the handshake, but then it hangs...

test: add mocked Sock that can read/write custom data and/or CNetMessages

Works like a charm! I'll see if I can add them to the tests in #30332 as well. --- It worked for the Template Provider as well and was easy...

test: add mocked Sock that can read/write custom data and/or CNetMessages

@vasild it's probably easier to reverse those two commits: first move the implementation out, and then split the class.

test: add mocked Sock that can read/write custom data and/or CNetMessages

re-ACK e7cf8e8fc658e4559fcc64279c7bd854773ad6c2 This makes my dimmed zebra very happy for the first commit, and the second one is now much easier to read.

test: add mocked Sock that can read/write custom data and/or CNetMessages

re-ACK b448b014947093cd217dbde47c8fb9e6c2bc8ba3

test: add mocked Sock that can read/write custom data and/or CNetMessages

Feel free to tag me in such a PR.