Yuriy Matskanyuk
Yuriy Matskanyuk
I suppose, since gpui-component provide only set of components, they are not binding it with system APIs or something like this, you will need to add a second implementation for...
@setchy here is PR
> @SiriusCrain - does the test suite run for you? I am AFK, will check when can
> I've also got a handful of other tailwind padding/margin changes locally to contribute later... I think you can add them or here or after merge, how will be ok...
> I've also got a handful of other tailwind padding/margin changes locally to contribute later... Problem with tests because jest cannot properly handle ESM syntax on which primer rely a...
> > Problem with tests because jest cannot properly handle ESM syntax on which primer rely a lot, so I think it will be easier to migrate from jest first...
@setchy do you need help with this too?
> > @setchy do you need help with this too? > > Help would be great. I've had a few timeboxed attempts. The experimental primer `Banner` component is giving some...
> primer v37 triggers these compilation issues when using the experimental components. My guess is it may be an upstream change > > ``` > Error: src/renderer/components/settings/SettingsReset.tsx(4,24): error TS2307: Cannot...
@setchy I checked it. 1. `experimental` path was fixed by changing both `module` and `moduleResolution` to 'nodenext' 2. They are moving away from `styled-components` in favor of CSS Modules, so...