gitify icon indicating copy to clipboard operation
gitify copied to clipboard

chore: primer react 37

Open SiriusCrain opened this issue 7 months ago • 8 comments

SiriusCrain avatar Jun 01 '25 12:06 SiriusCrain

@setchy here is PR

SiriusCrain avatar Jun 01 '25 12:06 SiriusCrain

@SiriusCrain - does the test suite run for you?

setchy avatar Jun 01 '25 14:06 setchy

@SiriusCrain - does the test suite run for you?

I am AFK, will check when can

SiriusCrain avatar Jun 01 '25 14:06 SiriusCrain

I've also got a handful of other tailwind padding/margin changes locally to contribute later...

setchy avatar Jun 01 '25 14:06 setchy

I've also got a handful of other tailwind padding/margin changes locally to contribute later...

I think you can add them or here or after merge, how will be ok for you

SiriusCrain avatar Jun 01 '25 15:06 SiriusCrain

I've also got a handful of other tailwind padding/margin changes locally to contribute later...

Problem with tests because jest cannot properly handle ESM syntax on which primer rely a lot, so I think it will be easier to migrate from jest first

SiriusCrain avatar Jun 01 '25 20:06 SiriusCrain

Problem with tests because jest cannot properly handle ESM syntax on which primer rely a lot, so I think it will be easier to migrate from jest first

We've tried in the past and it was not super easy as we had a lot of the mocking was not working. But I can't completely recall.

afonsojramos avatar Jun 02 '25 09:06 afonsojramos

Problem with tests because jest cannot properly handle ESM syntax on which primer rely a lot, so I think it will be easier to migrate from jest first

We've tried in the past and it was not super easy as we had a lot of the mocking was not working. But I can't completely recall.

I get it, I am afraid that we cannot upgrade right now because of jest

SiriusCrain avatar Jun 02 '25 09:06 SiriusCrain