gitify icon indicating copy to clipboard operation
gitify copied to clipboard
verified publisher icon gitify-app

chore(deps): update @primer/react to v37

Open renovate[bot] opened this issue 11 months ago • 13 comments

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@primer/react 36.27.0 -> 37.27.0 age adoption passing confidence

Release Notes

primer/react (@​primer/react)

v37.27.0

Compare Source

Minor Changes
Patch Changes

v37.26.0

Compare Source

Permalink to Documentation

Minor Changes
Patch Changes

v37.25.0

Compare Source

Minor Changes
Patch Changes

v37.24.0

Compare Source

Minor Changes
Patch Changes

v37.23.0

Compare Source

Minor Changes
Patch Changes

v37.22.0

Compare Source

Minor Changes
Patch Changes

v37.21.0

Compare Source

Minor Changes
Patch Changes

v37.20.0

Compare Source

Minor Changes
Patch Changes

v37.19.1

Compare Source

Patch Changes

  • Update data table pagination pageEnd to handle zero based index

  • b926c08 Thanks @​AAugustine! - Update data table pagination pageEnd to handle zero based index

v37.19.0

Compare Source

Minor Changes
Patch Changes

v37.18.0

Compare Source

Permalink to documentation
Minor Changes
Patch Changes

v37.17.0

Compare Source

Minor Changes
Patch Changes

v37.16.0

Compare Source

Minor Changes
Patch Changes

v37.15.0

Compare Source

Minor Changes
Patch Changes

v37.14.0

Compare Source

Minor Changes
Patch Changes

v37.13.0

Compare Source

Minor

Configuration

📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • [ ] If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate[bot] avatar Jan 20 '25 15:01 renovate[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Feb 06 '25 15:02 sonarqubecloud[bot]

@setchy do you need help with this too?

SiriusCrain avatar May 27 '25 14:05 SiriusCrain

@setchy do you need help with this too?

Help would be great. I've had a few timeboxed attempts. The experimental primer Banner component is giving some headaches

setchy avatar May 27 '25 14:05 setchy

@setchy do you need help with this too?

Help would be great. I've had a few timeboxed attempts. The experimental primer Banner component is giving some headaches

Do we use some component which need to be replaced with Banner, or they implemented some breaking changes?

SiriusCrain avatar May 27 '25 15:05 SiriusCrain

primer v37 triggers these compilation issues when using the experimental components. My guess is it may be an upstream change

Error: src/renderer/components/settings/SettingsReset.tsx(4,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.
Error: src/renderer/routes/LoginWithOAuthApp.tsx(19,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.
Error: src/renderer/routes/LoginWithPersonalAccessToken.tsx(19,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.

setchy avatar May 27 '25 15:05 setchy

primer v37 triggers these compilation issues when using the experimental components. My guess is it may be an upstream change

Error: src/renderer/components/settings/SettingsReset.tsx(4,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.
Error: src/renderer/routes/LoginWithOAuthApp.tsx(19,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.
Error: src/renderer/routes/LoginWithPersonalAccessToken.tsx(19,24): error TS2307: Cannot find module '@primer/react/experimental' or its corresponding type declarations.
  There are types at '/Users/runner/work/gitify/gitify/node_modules/@primer/react/lib-esm/experimental/index.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.

Thank you for clarification, I will check

SiriusCrain avatar May 27 '25 15:05 SiriusCrain

@setchy I checked it.

  1. experimental path was fixed by changing both module and moduleResolution to 'nodenext'
  2. They are moving away from styled-components in favor of CSS Modules, so probably styling and self-written components will require refactoring.
  3. Self-written components like Tooltip currently breaking the app, so I will try to fix/rewrite them, or adapt similar components from premier

What do you think about it?

SiriusCrain avatar May 29 '25 18:05 SiriusCrain

@setchy I checked it.

  1. experimental path was fixed by changing both module and moduleResolution to 'nodenext'
  2. They are moving away from styled-components in favor of CSS Modules, so probably styling and self-written components will require refactoring.
  3. Self-written components like Tooltip currently breaking the app, so I will try to fix/rewrite them, or adapt similar components from premier

What do you think about it?

Nevermind, it was not because of self written tooltip, I almost fixed it and will push later, need some time to test locally and investigate strange issues

SiriusCrain avatar May 29 '25 20:05 SiriusCrain

@setchy I will close this PR because I cannot push my changes here or create a PR EDIT: I cannot close it, fix pls

SiriusCrain avatar Jun 01 '25 09:06 SiriusCrain

@setchy I will close this PR because I cannot push my changes here or create a PR EDIT: I cannot close it, fix pls

FYI about changes, for some reason most of the paddings or sizes increased twice, so I manually decreased them, unfortunately have not found root cause or how to avoid such issue clearly

SiriusCrain avatar Jun 01 '25 10:06 SiriusCrain

@setchy I will close this PR because I cannot push my changes here or create a PR EDIT: I cannot close it, fix pls

Thanks for taking a look...

I'll be leaving this PR open since the major upgrade is still required...

setchy avatar Jun 01 '25 10:06 setchy

@setchy I will close this PR because I cannot push my changes here or create a PR EDIT: I cannot close it, fix pls

Thanks for taking a look...

I'll be leaving this PR open since the major upgrade is still required...

Ok, then I will push it to another branch) I asked to close it so I can create with the same branch name, because I already did it locally, but cannot push here because of 403

SiriusCrain avatar Jun 01 '25 11:06 SiriusCrain

All of the changes are ready for review btw, for some reason when I push it to my fork it is not asking to create PR, maybe because branch name is already used here

SiriusCrain avatar Jun 01 '25 11:06 SiriusCrain

replaced by https://github.com/gitify-app/gitify/pull/2221

setchy avatar Sep 10 '25 22:09 setchy