SinisterRectus
SinisterRectus
> It might be nice to add some test cases that exercise the functionality that is different after this PR. @RiskoZoSlovenska Any interest writing some tests? The original file is...
I will review and possibly include this after 2.11.0.
The type difference is explained [here](https://discord.com/developers/docs/reference#id-serialization) (#1078), but does conflict with the "always" language that you quoted. Edit: This exception applies to user provided input, so maybe it's irrelevant.
I know this is probably the easiest fix, and probably not likely to break things, but it is technically a breaking change. I wonder if we could just copy paste...
I'm okay with code duplication at this point. I'd rather do that than change the inheritance tree. 3.0 has one channel class and I expect it to stay that way...
> As a reminder, we do not start tracking pull/merge requests until October 1st. PR/MRs created before then won't be tracked. You would need to open a new one.
To add to that: Native integer support was added with 5.3 and remains in the current 5.4, the version that the online demo uses.
It looks like this changes the enum type from number to LJ int. Not ideal, but is there no better way?
I'm not sure exactly what's going on here. Can you dump the contents of your enum table? Just try `p(discordia.enums.permission)`.