SinisterRectus

Results 147 comments of SinisterRectus

Some Discordia users have reported similar occurences. Their streams stop while using youtube-dl and FFmpeg. Likewise, the audio can be fully downloaded to a file and played without issue. I'll...

Also https://github.com/phusion/holy-build-box/blob/master/README.md#why-statically-linking-to-glibc-is-a-bad-idea

Sorry this PR was neglected. This change looks okay to me. Can you give an example of it working as intended? Also, this would need a minor version bump.

Hi, thank you for this PR and for your patience. I am going to go through it one step at a time so that I understand it.

Overall I think it looks okay. But this is honestly outside of my understanding. I would legitimately have to rewrite all of lit to figure out how lit and git...

Maybe you can write a test file for this? We have limited testing on lit. Always room for more.

There is a bit of a descrepency between how errors are handled between some of the coro packages. Some return nil, err, some throw the error. Changing this now may...

I agree, I prefer that style. Some discrepancies I am referring to are: - coro-http [asserts net.connect](https://github.com/luvit/lit/blob/master/deps/coro-http.lua#L74), coro-websocket [does not](https://github.com/luvit/lit/blob/master/deps/coro-websocket.lua#L146) - there are [error](https://github.com/luvit/lit/blob/master/deps/coro-websocket.lua#L166) [calls](https://github.com/luvit/lit/blob/master/deps/coro-websocket.lua#L170) in the websocket handshake closure,...

I'll see what I can do then. It'll take some time to deconstruct everything, but it shouldn't be too challenging.

Wrong place. Try https://github.com/SinisterRectus/Discordia/issues.