Simen Bekkhus

Results 1237 comments of Simen Bekkhus

@ryzokuken @rosaxny any news? Being able to add Node's "extra" globals into a `vm.Context` without breaking `instanceof` would be lovely and fix some very confusing bugs in Jest.

With Node 15 adding a few more globals (`Event`, `EventTarget`, `AbortController` etc.) this is problem is more and more likely to hit consumers. Any chance of some movement here that's...

I've added some code to Jest to try to inspect the current env and copy over globals (https://github.com/facebook/jest/blob/49393d01cdda7dfe75718aa1a6586210fa197c72/packages/jest-environment-node/src/index.ts#L74-L103, not sure if the semantics using `Object.defineProperty` are correct), but I'd still...

Seems to me the last comment before the bot indicates something like this is still planned, so I don't think it's stale 🙂

That last one might be a bug/race condition in Jest's implementation still. I haven't found the time to dig into it properly since opening up the issue, unfortunately. It _feels_...

The above linked v8 issue has been closed as fixed now (:tada:) - any idea of when we'll know if it's enough for Node's use cases?

Ah ok, thanks for the link! Seems there's quite a bit of activity recently, so hopefully it's not too far away 🙂

Should #44211 be added to the OP?

After 2.5 years, one of the issues in the OP can finally be checked off 😀