Simen Bekkhus

icon indicating an email [email protected]

icon company @cvpartner icon location Oslo, Norway

Results 1237 comments of Simen Bekkhus

chore: move `@jest/test-utils` reference

👋

chore: move `@jest/test-utils` reference

Great stuff, thanks!

Make v8 coverage the default, get rid of babel-plugin-istanbul.

Exciting! I'm with you on switching the default, but do we need to get rid of the option? For people who want to keep using babel to instrument, for whatever...

Make v8 coverage the default, get rid of babel-plugin-istanbul.

I think I still prefer keeping `coverageProvider` option at least for one more release. While I don't think there have been any bugs reported with the v8 coverage, I assume...

Make v8 coverage the default, get rid of babel-plugin-istanbul.

Thanks @Smrtnyk! I think @cpojer is planning to tweet out asking people to test - happy to get some early results! 🙂 EDIT: haha, great timing 😀 --- One thing...

fix: mocking of getters/setters on automatically mocked classes

> The test,'can mock a function export', is [here](https://github.com/facebook/jest/pull/13460/commits/f329d8a8d62220981e3bc4eb516cbb86db4e5a46#diff-adaf06eece3e70e30d8f2f10bb676f7a9fb349e1ba622cc7bdc23e0250105a53). The restoring of the original property fails and is not tested. Can anyone tell me how to make this a valid...

fix: mocking of getters/setters on automatically mocked classes

Should add a test for it at least

fix: mocking of getters/setters on automatically mocked classes

I need to make a release for Node 19 today btw, so I might have to revert (again 😅)

fix: mocking of getters/setters on automatically mocked classes

I reverted the original PR in #13472 (but kept a bunch of tests). I'll merge in `main` here

fix: mocking of getters/setters on automatically mocked classes

> @SimenB I've reapplied the automatic mocking tests that were removed, and reapplied the original spyOn method structures. Apologies again for the hassle caused. Thanks! And don't worry about the...