Simen Bekkhus comments

Results 1237 comments of


                                            Simen Bekkhus

Upgrade from source-map 0.6.1 to @cspotcode/source-map-consumer 0.8.0

Most of this PR has conflicts due to #12692. Only the e2e test that we'd want to do this in, I think?

Upgrade from source-map 0.6.1 to @cspotcode/source-map-consumer 0.8.0

wat, `Pinned` label is here??

Upgrade from source-map 0.6.1 to @cspotcode/source-map-consumer 0.8.0

🤔

[Bug]: 0 is not considered equal to -0?

This is by design, we use [`Object.is`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is). That said, I _might_ be convinced that `toEqual` should report them as the same, but we have an explicit test today that they're...

[Bug]: Reporter.onTestCaseResult not called for test.todo in Jest 27

This seems reasonable to fix.

[Bug]: Reporter.onTestCaseResult not called for test.todo in Jest 27

Go for it 👍

[Bug]: Reporter.onTestCaseResult not called for test.todo in Jest 27

https://github.com/facebook/jest/releases/tag/v29.5.0

Hooks cannot be defined inside tests. Hook of type "beforeEach" is nested within "check for App".

Please include a reproduction.

Clearer jsdomError messages

Sorry about the missing response @haroldhues! I had over 3k notification on GH and I'm currently trying to wade through them 😅 Could you send this PR to Jest core?...

Clearer jsdomError messages

03837baa9afc9dce0bdbf8c711401571646a723f But yes, sending a PR with this to Jest core would be appreciated 👍