Simen Bekkhus
Simen Bekkhus
Can you add an integration test with some snapshots showing what the errors look like if you use the matchers inside your own?
I don't mind internal matchers having access. Probably easier to have some `InternalMatcher` type which excludes it if we want anyways (if we wanna prevent it)
I'm thinking this is fine as is and we can make the types better in a future patch. Unless you're currently working on the types @JVBorges?
Cool, thanks! 👍
This is a great start, thanks for working on it! I have no comments beyond the ones left by @mrazauskas 👍 And yeah, tests that assert options passed through are...
>I would do the same in all the matchers and test where styled strings are printed. > >To ensure that there are no hardcoded colors used somewhere, I'm not passing...
@Joshua-Hwang hey! CI isn't kicking in since you've changed your user to one that's "not" a contributor. I can try to remember to click the button when you push, tho...
I recently was sent [this](https://www.rubydoc.info/gems/minitest/Minitest%2FTest.i_suck_and_my_tests_are_order_dependent!) and it made me think of this PR 😅 let's get it in!
Sorry, missed this! @pxpeterxu I resolved the conflict locally, but I'm not allowed to push to your remote - could you check this box in the lower right?
ping @pxpeterxu