Simen Bekkhus comments

Results 1229 comments of


                                            Simen Bekkhus

Support for 'redis' client

I asked in https://github.com/mike-marcacci/node-redlock/pull/84#issuecomment-1032374391 as well. Supporting the closest thing to an official node client seems sensible. v4 can probably work in `legacyMode: true` (`connect-redis` does)

srcSet not converted to srcset

Can't we do `toLowerCase` on everything that's passed onto DOM nodes?

Error during loading "angular-webpack/node_modules/karma-phantomjs-launcher" plugin: Path must be a string. Received null

#191 trying to fix this, or at least provide a better error message

Mac Os Sierra "Cannot start PhantomJS"

#191 trying to fix `Path must be a string. Received null`, or at least provide a better error message

Try to find phantomjs binary in `.bin`

@dignifiedquire CI fails because of mismatch in peer deps, which threw on old npms. Also failing on master

fix: update `long` to v5

#2111 was fixed in https://github.com/googleapis/gax-nodejs/pull/1253. The two other PRs just seems to try to deal with the fallout from that before `google-gax` got fixed?

fix: update `long` to v5

Sweet! Not sure if there's anything I'm supposed to do about the test failure? Seems spurious at first glance

fix: update `long` to v5

😅

`grpc.Client.close()` should have a callback when all calls complete

My server in this case is an express.js server serving user facing http traffic, not a grpc server. And this express app speaks grpc to the backend. When the app...

jest-runner-eslint disagreeing with command line eslint and editor

Could you put together a reproduction we could pull down and see the error? We just use `eslint`'s programmatic api, so different results sounds weird