Simen Bekkhus

Results 1232 comments of Simen Bekkhus

Does the app leak even if you remove your own metrics?

No, OP is using v9, the problem was only in v10

What happens if you do a `delete request.startTime` after reading it? Maybe it isn't GCed properly

Should you be using the `plugins` part of the request? https://hapijs.com/api#request-properties Or maybe `app` (if `app` is per request)? I've never used hapi, just trying to be a good rubber...

(I just edited to add syntax highlighting). I agree that that code snippet looks OK.

Help tracking down the leak would be very much appreciated! We're running this in production at work without a leak, so it's probably some special combination of either metrics, labels...

Shouldn't have any effect as long as you don't mess with the `require.cache` object so things are loaded multiple times

Do you have a reproduction showing that it leaks?