grpc-node icon indicating copy to clipboard operation
grpc-node copied to clipboard
verified publisher icon grpc

fix: update `long` to v5

Open SimenB opened this issue 3 years ago • 2 comments

protobufjs@7 (#2167) comes with it, so aligning seems sensible to me

SimenB avatar Aug 09 '22 10:08 SimenB

Please see #2110, #2112, and #2114 for the last time we tried this.

murgatroid99 avatar Aug 09 '22 16:08 murgatroid99

#2111 was fixed in https://github.com/googleapis/gax-nodejs/pull/1253. The two other PRs just seems to try to deal with the fallout from that before google-gax got fixed?

SimenB avatar Aug 10 '22 06:08 SimenB

Sweet! Not sure if there's anything I'm supposed to do about the test failure? Seems spurious at first glance

SimenB avatar Aug 17 '22 09:08 SimenB

No, it's fine.

murgatroid99 avatar Aug 17 '22 16:08 murgatroid99

This is now out in v0.7.1

murgatroid99 avatar Aug 17 '22 17:08 murgatroid99

Unfortunately this broke gax again, so I had to revert it in 0.7.2.

murgatroid99 avatar Aug 17 '22 20:08 murgatroid99

😅

SimenB avatar Aug 17 '22 21:08 SimenB