Simen Bekkhus comments

Results 1229 comments of


                                            Simen Bekkhus

Merging of registers ignores default labels

Heh, I did raise the point in the original PR: https://github.com/siimon/prom-client/pull/137#issuecomment-311408833. Not sure what the expected behavior would be here? Existant default labels hsould be copies, but not automatically applied...

feature: remote write

PR welcome? 😀

Compliancy the default metrics with Prometheus Naming Convention

PR very much welcome fixing all metric names!

Add event loop utilization as a default metrics

Yeah, sounds reasonable!

feat: support aggregating metrics across workers in a Node.js worker_…

Dropping node 10 must be done in a major release, but we can probably do one of those?

remove unnecessary necessity of predeclared, known-at-declaration-time labelset for metrics

How does this impact the TS types?

Aggregation of t-digest types broken by default

I'm not sure what concretely you're asking? Are you asking how the aggregation works in this library before the scrape by prometheus? I'm also not sure what "worker" and "master"...

Aggregation of t-digest types broken by default

@zbjornson ^

Does prom-client handle missing metrics?

Related, with docs reference: https://github.com/siimon/prom-client/issues/233#issuecomment-450903295

Compatibility with pushgateway not exposing /metrics/job/...

@zbjornson thoughts on this one?