Simen Bekkhus comments

Results 1229 comments of


                                            Simen Bekkhus

Support Bigint

PR welcome - our current minimum node version is 10 👍

add the ability to stop the event loop

>I also fixed a bug in the tests where a failed assertion in a setTimeout wasn't properly rejecting the test promise. Since we're waiting for node to respond, maybe that...

Add custom collectors / collectors support

@siimon thoughts on this one?

Service discovery is the responsibility of Prometheus

It came from #83 (feature request) and #137 (PR), cc @goofballLogic @nwest1 thoughts?

Suggested pattern for metrics in libraries

We should most definitely document this. At work we have `prom-client` as a `peerDependency` to ensure there is only one in the entire application. We have been playing around with...

Counter reset that sets every value to zero

>It is initialized to zero for all possible values of the label, as is a best practice for counter metrics. I haven't seen that before, mind pointing to the docs...

Counter reset that sets every value to zero

Thanks for the links! >Most Prometheus client libraries (including Go, Java, and Python) will automatically export a `0` for you _for metrics with no labels_. (emphasis mine) that's not the...

Add openmetrics and exemplars support

Very exciting, thanks for working on this!

Allow master to add its own metrics

I've never used the cluster code, @zbjornson?

Labels values containing a " are not escaped, leading to "no token found" scraping error

Should we escape it, or throw ourselves (with a clear error) and make the consumer escape it?