Simen Bekkhus
Simen Bekkhus
@keeganwitt @mattphillips thoughts?
`toHaveBeenCalledOnce` added via #274, still missing `toHaveBeenCalledOnceWith` if anyone is up for it 🙂
Could you put together a small reproduction?
Right, we should probably not force it to take a mock, and just something callable instead. It _needs_ to be called with a mock tho, so maybe it's correct and...
where does `jest-extended` use `jest`? it should only use `expect`, which is still a global (unless you've disabled it)
right. if you disable the globals you'll need to extend yourself. ```js import {expect} from '@jest/globals'; import jestExtendedMatchers from 'jest-extended'; expect.extend(jestExtendedMatchers); ``` we can probably expose some `/all-imported` thing which...
@mattphillips you gonna complete this? 😀
I haven't touched the example, not sure why lint is failing for that now. Note that I get way more lint failures locally, but they're all also on master, so...
Should these be set to `16.x || 17.x` or something while we're waiting for v18 support? https://github.com/vadimdemedes/ink/blob/ba6b7ea0fd749829c2b612106213cc67a6271267/package.json#L102-L103
We wanna revamp our mocking API in Jest, so any suggestions that come out of this are very much welcome! Some discussion here: https://github.com/facebook/jest/issues/5969