Sheng Yang
Sheng Yang
> So sorry for the delay! I have minor comments. Thanks:) I have addressed all of your comments.
> There's a new policy requiring all new PRs adding new functionality to provide tests. Could you please add a test that creates a mock SYCL device and test the...
> @ShengYang1 Could you please rebase the PR on top of the latest state of the repo? Thanks! Done.
> > @ddunl This fails to import internally because copybara isn't sure where to put the new spirv files. It seems like it requires some extra configuration. Could you please...
> @ShengYang1 Sorry for the delay on this PR. I believe we're finally in a state where we can merge it. Can you please rebase on the latest revision and...
Yes, this is a problem of "PJRT C API" Interface design and we need support from OpenXLA side. https://github.com/openxla/xla/blob/main/xla/pjrt/pjrt_c_api_client.h#L281-L285