xla icon indicating copy to clipboard operation
xla copied to clipboard

Published 20 hours ago • verified publisher icon openxla

[XLA:GPU] Add SPIRV-LLVM-Translator and translation pass

Open ShengYang1 opened this issue 10 months ago • 2 comments

It is a sub PR of https://github.com/openxla/xla/pull/9042 to add spirv-llvm-translator and translation pass

ShengYang1 avatar Apr 11 '24 02:04 ShengYang1

Hi @penpornk , could you please review this PR? Thanks.

kamaljeeti avatar May 07 '24 05:05 kamaljeeti

Hi @penpornk This PR has been approved but not yet merged, Can you please look into this.

NaiyerRizz avatar May 14 '24 09:05 NaiyerRizz

@ShengYang1 Could you please rebase the PR on top of the latest state of the repo? Thanks!

dimitar-asenov avatar May 16 '24 09:05 dimitar-asenov

@ShengYang1 Could you please rebase the PR on top of the latest state of the repo? Thanks!

Done.

ShengYang1 avatar May 17 '24 06:05 ShengYang1

@ddunl This fails to import internally because copybara isn't sure where to put the new spirv files. It seems like it requires some extra configuration. Could you please advise what's needed to merge this? Thanks.

dimitar-asenov avatar May 17 '24 11:05 dimitar-asenov

@ddunl This fails to import internally because copybara isn't sure where to put the new spirv files. It seems like it requires some extra configuration. Could you please advise what's needed to merge this? Thanks.

TSL repository cannot be changed via PRs, you need to copy the changes manually as all changes to TSL repo are not imported.

akuegel avatar May 24 '24 05:05 akuegel

@ddunl This fails to import internally because copybara isn't sure where to put the new spirv files. It seems like it requires some extra configuration. Could you please advise what's needed to merge this? Thanks.

TSL repository cannot be changed via PRs, you need to copy the changes manually as all changes to TSL repo are not imported.

@akuegel Should I submit another PR for tsl changes?

ShengYang1 avatar May 28 '24 07:05 ShengYang1

@ddunl This fails to import internally because copybara isn't sure where to put the new spirv files. It seems like it requires some extra configuration. Could you please advise what's needed to merge this? Thanks.

TSL repository cannot be changed via PRs, you need to copy the changes manually as all changes to TSL repo are not imported.

@akuegel Should I submit another PR for tsl changes?

No, unfortunately it can only be changed internally.

@xla-rotation importing this PR requires manual work, see comments above.

akuegel avatar May 28 '24 08:05 akuegel

This PR needs https://github.com/openxla/xla/pull/11425 to be submitted first together with some internal changes. I'm working on those. Once that other PR is in, I will look into this one.

dimitar-asenov avatar Jul 10 '24 08:07 dimitar-asenov

@ShengYang1 Sorry for the delay on this PR. I believe we're finally in a state where we can merge it. Can you please rebase on the latest revision and ping me here? Thanks!

dimitar-asenov avatar Aug 05 '24 12:08 dimitar-asenov

@ShengYang1 Sorry for the delay on this PR. I believe we're finally in a state where we can merge it. Can you please rebase on the latest revision and ping me here? Thanks!

Thanks for your effort. I have already rebased.

ShengYang1 avatar Aug 06 '24 00:08 ShengYang1

Once again, merging this is more challenging than expected due to the newly added dependencies. Sorry for the delay.

dimitar-asenov avatar Aug 08 '24 14:08 dimitar-asenov

This has not fully landed yet due to changes in tsl.

I'll let you know once this lands.

golechwierowicz avatar Aug 09 '24 11:08 golechwierowicz

This change should be in.

golechwierowicz avatar Aug 09 '24 15:08 golechwierowicz

This change should be in.

We've been notified that the changes are merged and I have updated the internal PR track list, thank you very much!

Zantares avatar Aug 13 '24 03:08 Zantares