Eric P Sheets

Results 178 comments of Eric P Sheets

The 0.8 and 0.12 errors stem from a cc invocation whose meaning has changed: - 0.12: https://github.com/nodejs/node/blob/v0.12/configure#L483 - 0.8: https://github.com/nodejs/node/blob/v0.8.28/configure#L330 Older gcc versions used to print semver with the `-dumpversion`...

The core logic has been factored out since both `Buffer.isEncoding` and `Buffer#toString` have to check the encoding. For the case insensitive matching, raw bit-ops are preferred since the `strcmp` variants...

0.1.8 regressed. All four steps now segfault: ``` $ git clone --depth=1 https://github.com/Chevrotain/chevrotain/ $ cd chevrotain/examples/tutorial/ $ bun install $ for i in step*; do (cd $i; bun main.js; cd...

The unexpected implementation structure stems from the actual DNS API https://nodejs.org/dist/latest-v18.x/docs/api/dns.html . [Node v6](https://nodejs.org/docs/latest-v6.x/api/dns.html) only had the top-level methods like `dns.resolve`. Node v8 added the `Resolver` class and v10 added...

[PR 929 implements a DoH fallback against cloudflare](https://github.com/oven-sh/bun/pull/929). Note that after the patch, modules are still blocked by other issues like `tls` / `net#Socket` / RegExp lookbehind.

The tests predictably failed on old node versions since they did not support ES6 destructuring. Did you test against the examples provided by @snoopyjc in https://github.com/SheetJS/sheetjs/issues/2560#issuecomment-1062838050 ?

Nothing else on your end. There are some logistical issues we are figuring out regarding date handling. Ideally, 0.19.0 resolves the outstanding date processing problems which requires both the SSF...

We'll revisit dates later this month. Please don't merge with latest, as the actual commits can be cherrypicked as needed. Given the [4-year old V8/NodeJS/Chrome timezone bug](https://bugs.chromium.org/p/v8/issues/detail?id=7863) and the declining...

ES6 issues aside (we are targeting ES3, so no const or default parameter values or arrow functions) two comments: 1) the result of the match is not used, so [RegExp#test](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/test)...

Here's a quick sample to test a few features: [BIFF8 XLS](https://gist.githubusercontent.com/SheetJSDev/ba7b8f59a19a5819d77303e1c97c28a1/raw/b17d8c8a84ed3496dd7801db6207aebcc47269d0/picture_test.xls) [BIFF5 XLS](https://gist.githubusercontent.com/SheetJSDev/ba7b8f59a19a5819d77303e1c97c28a1/raw/b17d8c8a84ed3496dd7801db6207aebcc47269d0/picture_test5.xls) [XLSX](https://gist.githubusercontent.com/SheetJSDev/ba7b8f59a19a5819d77303e1c97c28a1/raw/b17d8c8a84ed3496dd7801db6207aebcc47269d0/picture_test.xlsx) [XLSB](https://gist.githubusercontent.com/SheetJSDev/ba7b8f59a19a5819d77303e1c97c28a1/raw/b17d8c8a84ed3496dd7801db6207aebcc47269d0/picture_test.xlsb) [XLML](https://gist.githubusercontent.com/SheetJSDev/ba7b8f59a19a5819d77303e1c97c28a1/raw/b17d8c8a84ed3496dd7801db6207aebcc47269d0/picture_test.xml) [ODS](https://gist.githubusercontent.com/SheetJSDev/ba7b8f59a19a5819d77303e1c97c28a1/raw/b17d8c8a84ed3496dd7801db6207aebcc47269d0/picture_test.ods) [FODS](https://gist.githubusercontent.com/SheetJSDev/ba7b8f59a19a5819d77303e1c97c28a1/raw/b17d8c8a84ed3496dd7801db6207aebcc47269d0/picture_test.fods) The different workbook formats use different image filetypes (is that really a...