sheetjs icon indicating copy to clipboard operation
sheetjs copied to clipboard

Published 20 hours ago • verified publisher icon SheetJS

fix date/time rounding issue

Open scottysseus opened this issue 3 years ago • 6 comments

See: #2560

  • Improved rounding to account for minutes, hours, etc.
  • Added tests for rounding dates/times

scottysseus avatar Jun 15 '22 18:06 scottysseus

The tests predictably failed on old node versions since they did not support ES6 destructuring.

Did you test against the examples provided by @snoopyjc in https://github.com/SheetJS/sheetjs/issues/2560#issuecomment-1062838050 ?

SheetJSDev avatar Jun 20 '22 19:06 SheetJSDev

Thanks for the quick reply, @SheetJSDev. I have added @snoopyjc's test cases, and the syntax should be fully compatible with ES3 now.

scottysseus avatar Jun 21 '22 21:06 scottysseus

@SheetJSDev I would like to get this change merged if there aren't any other issues and you think it's appropriate. Is there anything else I need to do?

scottysseus avatar Jul 13 '22 13:07 scottysseus

Nothing else on your end. There are some logistical issues we are figuring out regarding date handling.

Ideally, 0.19.0 resolves the outstanding date processing problems which requires both the SSF formatting library and the main file processing library to agree on date code interpretation.

SheetJSDev avatar Jul 15 '22 07:07 SheetJSDev

Thanks for all your work!

MrToadie avatar Sep 10 '22 10:09 MrToadie

Are there any updates on this? At a quick glance, I'm not able to reproduce this here: https://oss.sheetjs.com/ssf/

but want to make sure this has been fixed and what version it's been fixed in

scottysseus avatar Nov 22 '23 19:11 scottysseus