Antonio Salazar Cardozo

Results 286 comments of Antonio Salazar Cardozo

@greg-nagy what's the story with this PR?

Uniswap is already included in our overall list I believe. It sounds like #1846 covers the rest of this issue? Feels like we can consolidate if so.

Gas estimation reverts deserve their own admonition for the user, fwiw. Do you see a snackbar indicating the tx failed?

Picked this guy up. Also, [possible related issue](https://www.flowdock.com/app/cardforcoin/tech/threads/rff113IIrTgzCzZ4NXkWt9ld-mr).

Compiling in an external package that has unlimited access to our memory just to set an environment variable seems odd… I'm interested in finding a better way to get this...

I think this causes issues with the openzeppelin stuff, from what I remember from tbtc.

> gotten anywhere Late to the question ofc, but I'm not sure what this question was meant to be asking in the first place. We aren't doing this, so in...

Latest research on gas costs of funding proofs is here: https://docs.google.com/spreadsheets/d/1YgNNqx_bnN54yggX-X8OQbyCX6B1U-7TBcrqsGlxay0/edit?usp=sharing

> Build a maintainer to challenge deposits based on prices from popular exchanges Probably want to integrate this into an existing executable (e.g. tbtc-maintainer), otherwise we're upping the operational overhead...

Removed this from the sprint board until we do a prioritization pass post-mainnet. We are shipping v1 without attributability, and with 3-of-3 signing.