Antonio Salazar Cardozo

Want to flag that it's going to be bad form in general to do security-critical background script changes (as with the keyring service) in the same PR as UI stuff....

We already have the internal list--that is what the custom asset stuff is I believe. This todo explains a reasonable path to adding the relevant metadata there: https://github.com/tallycash/extension/blob/6a69598bdab150ee1c0cebc3b81e05d6369a0fa6/background/services/indexing/index.ts#L294-L299

I think two paths we can take here and it's ultimately a product decision. We can nuke the baseline trust concept, always display the warning for non-token list assets without...

`0x2105dc7…` -> is this abbreviation done by the console or are we getting real weird in what we're sending here?

That is actually correct behavior--but we should probably queue enrichment for older transactions while fast-pathing signature requests.

This should get fixed with the updated signing flow fwiw. Up to y'all if you want to fix it on the old one in the meantime.

Let's start this by: - [ ] Implementing `getERC20TokenBalance` (singular!) using a normal Ethers provider and the ERC20 ABI at `lib/erc20.ts`. Then we need a way to do some good...

Ayyyy you right. `getBalance`! There goes the easy part 😂

Does it not work or is it just unsupported? The simplicity of brew trumps them not wanting to answer questions about it imo, unless we run into issues with it.

https://docs.brew.sh/Shell-Completion#configuring-completions-in-zsh seems to be the recommended path here. Overall torn as it's good to be default friendly to a macOS install in our install scripts though, and since zsh is...