Antonio Salazar Cardozo

Results 286 comments of Antonio Salazar Cardozo

Aye, I skimmed that. I think there's value to going all the way here and exposing status code and cause-as-string somehow. Again, the core issue will be the `liftVanilla` implementation...

(Despite my comment trying to lay out the options linked above, I'm 100% in favor of this approach.)

Went deep on this one. The issue here is that Sushi Guard expects a non-[EIP-191](https://eips.ethereum.org/EIPS/eip-191) signature. Sushi Guard constructs a transaction, hashes it, and requests a raw signature of the...

The issue is creating a malicious function whose sighash collides with a matching 4byte signature, not vice versa, no?

I had the mind flash of a variable rename the other day but forgot it before suggesting. I'd be fine with a rename that made it clear this wasn't a...

* just a tiny terminology note that these are messages, not transactions (and this is why they don't have a network).

What shows up in the fee details menu would be useful to know in this scenario.

Wow, this looks awesome! :tada: Thanks for presenting on the community call as well, I'm excited about what y'all are doing and it sounds like the community is too. A...

@geoist1 @mr-michael is going to be able to make the priority call here--we're stretched quite thin at the moment and my recollection is we wanted a more integrated design for...

> Transaction was not submitted This isn't necessarily true. What dropped *should* mean is “we don't expect this will ever be confirmed on-chain”. This can be for a variety of...