WIP --> 2011: complete draft of UI work for the change password feature

[rgdalessandro]

Description: This PR is a WIP (work-in-progress). This is a draft of UI-only changes. Background changes are not yet part of this PR. Closes #2011

Changes:

• create new feature flag --> ALLOW_CHANGE_PASSWORD
• UI changes to Settings.tsx and KeyringSetPassword.tsx
• A few tiny improvements to .gitignore, README.md, SharedInput.tsx, signing-hooks.ts and Popup.tsx

Before:

After:

To test:

• [ ] Set ALLOW_CHANGE_PASSWORD = true by adding the variable to your environment or editing the features.ts file.
• [ ] Navigate to the Settings page and click the new link for "Change password" to see the Change Password page.

[Shadowfiend]

~~Please change ALLOW_ to SHOW_. We are (very) slowly and so far semi-informally moving to a more consistent feature flag structure for UI things :)~~ Upon closer inspection, I'm not even following this right now, so I think I'm imagining things...

EDIT to say: also, welcome, awesome, thanks for looking at this!

[mhluongo]

Nit: No need to include "WIP" anywhere when a PR is in draft!

[0xDaedalus]

Hey @rgdalessandro - if you can please avoid force-pushing once a PR is out of draft - makes it quite difficult for those of us who review commit-by-commit

[Shadowfiend]

Want to flag that it's going to be bad form in general to do security-critical background script changes (as with the keyring service) in the same PR as UI stuff. It makes it harder to review, for code that is particularly crucial to review carefully.

To that end, and I realize this is going to require a force-push in spite of @0xDaedalus's request 😅, can we please:

• Move the commits that update background/services/keyring to a separate PR (it can be targeted at main or at this branch, whichever is easiest).
• Keep this PR focused on the UI pieces.

I realize this is a bit disruptive to the workflow of actually building out the feature*, but I think it will be helpful to split the conversations and the review along this security boundary.

[rgdalessandro]

Want to flag that it's going to be bad form in general to do security-critical background script changes (as with the keyring service) in the same PR as UI stuff. It makes it harder to review, for code that is particularly crucial to review carefully.

To that end, and I realize this is going to require a force-push in spite of @0xDaedalus's request 😅, can we please:

• Move the commits that update background/services/keyring to a separate PR (it can be targeted at main or at this branch, whichever is easiest).
• Keep this PR focused on the UI pieces.

I realize this is a bit disruptive to the workflow of actually building out the feature*, but I think it will be helpful to split the conversations and the review along this security boundary.

As requested, this PR has been split up into two PS's:

1. changes to the keyring service --> https://github.com/tallycash/extension/pull/2128

2. all other changes, including redux changes and ui changes remain in this PR (#2015)

[jagodarybacka]

This PR is stale and not aligned with the current roadmap - let's close it