Antonio Salazar Cardozo

Results 286 comments of Antonio Salazar Cardozo

Also I'd like to accidentally close this issue

Started looking at this a bit, btw. Lot of code to move around, but still hoping to get it done for 3.2.

Ugh, sorry @Bhashit… I kind of did this all in one day, and in my head you were working on the combinators but not the typing changes. Re-reading the original...

Pushed a bunch more changes here… One note for you @Bhashit particularly for `collectFailure` in #1864---I had to un-`final` the `collect` methods to provide more specific types in `PresenceBox` for...

Well no changes have been pushed so that seems perfectly reasonable :p

Sadly I had to jettison a properly-typed `flatten` implementation, at least for the time being. Details in [the commit](https://github.com/lift/framework/pull/1876/commits/a8f140202f3e3ac19effeec5d0401ffdfae866e8), but net-net I couldn't figure out how to get the compiler...

> I'm wondering whether or not we've made Box harder to understand conceptually and therefore increased the barrier to entry for using it and contributing to it. We've definitely increased...

Not quite complete yet, but I've added the structure I'll be using for the typing tests, as well as a first tranche of tests. I also figured out why `collect`...

Ok, so slight complication here which we'll need to decide if we're okay with… In a sense, this branch is too effective heh. `?~` now returns `TryBox`, as it should....

Ok, wrapped up the specs, made a fix or two, nuked the `= ???` definitions, and merged in master with @Bhashit's changes... I think I consider this PR good to...