Grigorii K. Shartsev comments

Results 583 comments of


                                            Grigorii K. Shartsev

fix(dashboard): performance and refactoring

> Not ready for review? > @ShGKme You might have accidentally committed a dev build :D It was in draft waiting for the base branch https://github.com/nextcloud/server/pull/41063 to be merged. Rebased...

[stable28] fix(files): selected files actions position on scroll/with readme block

/compile

[stable28] fix(files): selected files actions position on scroll/with readme block

@skjnldsv Can we merge it during the freeze as it has no translations/design changes and fixes a bug that is already in `stable28`?

[stable28] chore: Bump @nextcloud/vue to v8.5.1

Should we wait for 8.5.1 as there are critical bugs anyway?

[stable28] fix(settings): set viewBox on SVG icons

/compile

fix(files): drop to folder path and user feedback

I couldn't reproduce the issue from the linked comment... But fixes bulk upload to `/Photos/Album` for me Before | After ---|--- ![image](https://github.com/nextcloud/server/assets/25978914/00654759-041d-43b3-9b32-d009ebb1d9ad) | ![image](https://github.com/nextcloud/server/assets/25978914/523d15e8-9b31-4d88-98fd-7793273bd426)

[BITV] 9.4.1.2/6.3 - "Change scope" menus - Alle menus have been implemented using the aria-haspopup="menu" attribute, which informs users that a menu is being opened.(1)

> @ShGKme has this issue been resolved after call with Michael? No, this menu is a bit special with a custom design. I'll add more details later

[BITV] 9.4.1.2/6.3 - "Change scope" menus - Alle menus have been implemented using the aria-haspopup="menu" attribute, which informs users that a menu is being opened.(1)

Pending backport

[stable28] fix(settings): federation scope menu a11y

/compile amend

[BITV] 9.4.1.2/7.2 - The "Change color" button in the "Background" section opens an area where you can choose a background color. (1)

The labelling issue is to be fixed by https://github.com/nextcloud-libraries/nextcloud-vue/pull/4889 `aria-expanded` is a common `NcPopover` issue, mentioned in other issues.