Grigorii K. Shartsev

Results 583 comments of Grigorii K. Shartsev

I think, we should keep it. And I'd even return the icon prop to some components like NcButton. We have some JS API, where an icon class name is provided,...

> The only reason to have urls is for php APIs. And we are not going to get rid of using URLs in HTTP API, right? I guess, rendering pure...

Thanks for details explanation @skjnldsv 💙

But shouldn't we first get rid of icon-classes and URLs in JS/HTTP API and then remove such props from the components? Otherwise, we don't control if the icon is passed...

> * Make the text and icon `--color-text-maxcontrast` so that it looks like a disabled button Sounds very similar to the current style of `NcActionCaption`, except that `caption` has no...

> * Always add a separator under/above/both the NcActionText component so that it is separated from the rest of the buttons I think that could be an unexpected design change....

> very similar to the current style of `NcActionCaption` Maybe make caption centered? ![image](https://github.com/nextcloud-libraries/nextcloud-vue/assets/25978914/b20c7a81-e298-45eb-80b9-2aa13297cf6d)

> I would steer clear of using center alignment as that's something we rarely do for text/headings/captions. It would look something like this Note, the centered "Group caption" from my...

It is already supported by `NcDateTimePickerNative` as a native feature. but it doesn't work with a clipboard.