Grigorii K. Shartsev comments

Results 583 comments of


                                            Grigorii K. Shartsev

Add constants types

Vuex constants types in docs has the same problems as vuex project structure: examples in the docs are too simple and small (this is the reason why this repo exists)....

In the docs there is an example only for mutations: [Using Constants for Mutation Types](https://vuex.vuejs.org/guide/mutations.html#using-constants-for-mutation-types). I think, at least actions must have constants too. Even more, we call actions from...

Add constants types

Actually this is a very simple magic: https://github.com/vuejs/vuex/blob/dev/src/helpers.js#L117 Ok, let's do without createNamespacedHelpers (I must admit, I didn't remember this helper and found it after docs rereading today). I'll make...

NcActions open toggle flickers if devtools are opened

Can reproduce in Firefox when not just devtools but the Elements tab is open. It seems that the slowing part here is highlighting updates. Rendering of `NcActions` itself seems fast...

[BITV] 9.3.3.2/3.3 - Comment section: The input fields for creating and editing comments lack visual labels. The important note "Write message, use "@" to mention someone, use ":" for emoji autocompletion …," is only available as a placeholder element and should ideally be placed as visual text below the field linked to it via aria-describedby attribute. (2)

@michaelnissenbaum Is that correct that [`aria-placeholder`](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-placeholder) can be used here instead of `aria-describedby` for the placeholder?

[BITV] 9.3.3.2/3.3 - Comment section: The input fields for creating and editing comments lack visual labels. The important note "Write message, use "@" to mention someone, use ":" for emoji autocompletion …," is only available as a placeholder element and should ideally be placed as visual text below the field linked to it via aria-describedby attribute. (2)

> @jancborchardt what should be used as a placeholder when the text is moved below the field as a description? What about: 1. Make the default placeholder short (see https://github.com/nextcloud-libraries/nextcloud-vue/pull/4408)...

[BITV] 9.3.3.2/3.3 - Comment section: The input fields for creating and editing comments lack visual labels. The important note "Write message, use "@" to mention someone, use ":" for emoji autocompletion …," is only available as a placeholder element and should ideally be placed as visual text below the field linked to it via aria-describedby attribute. (2)

> Can someone add an image showing how the solution will look like? @rakekniven see https://github.com/nextcloud-libraries/nextcloud-vue/pull/4482

[BITV] 9.3.3.2/3.3 - Comment section: The input fields for creating and editing comments lack visual labels. The important note "Write message, use "@" to mention someone, use ":" for emoji autocompletion …," is only available as a placeholder element and should ideally be placed as visual text below the field linked to it via aria-describedby attribute. (2)

> I would avoid this long suggestion altogether in such small inputs. We can make the default description short and initial size of the text field 2 lines. For example,...

[BITV] 9.3.3.2/3.3 - Comment section: The input fields for creating and editing comments lack visual labels. The important note "Write message, use "@" to mention someone, use ":" for emoji autocompletion …," is only available as a placeholder element and should ideally be placed as visual text below the field linked to it via aria-describedby attribute. (2)

### Option 1: add visible description block - ✅ Supports custom content - ✅ Visible and accessible - ❌ Large, multiline for long instructions / small layout PR: https://github.com/nextcloud-libraries/nextcloud-vue/pull/4482 ![image](https://github.com/nextcloud/server/assets/25978914/f517d2da-7e50-4c36-88b1-bc3806b2ac44)...

NcCheckboxRadioSwitch: Allow external label

It is supposed to be used as ```html label ``` Then it has common styles, focus effect, etc. What is the use case to have the label outside the component?