server icon indicating copy to clipboard operation
server copied to clipboard

fix(dashboard): performance and refactoring

Open ShGKme opened this issue 1 year ago • 3 comments

Summary

~~⚠️ Chained on https://github.com/nextcloud/server/pull/41063~~

Polish a bit dashboard app:

  • [x] Decrease duplication of dashboard v1/v2
  • [x] Polish styles to replace classes like panel-activity--header--icon--description and very nested selectors with selectors by tags
  • [x] Improve dragging performance:
    • Dragging dashboard was very laggy
    • Hidden icon description with .hidden-visually has transforms that makes it terrible in performance with a combination of Draggable
    • This description is not needed, icon is hidden for a11y
    • Remove the hidden description
Before After
dashboard-laggy dashboard-after

Checklist

ShGKme avatar Oct 23 '23 14:10 ShGKme

@ShGKme ShGKme (Grigorii K. Shartsev) requested review from st3iny, susnux, JuliaKirschenheuter, skjnldsv, Pytal and szaimen 16 hours ago

Not ready for review? image

skjnldsv avatar Oct 24 '23 06:10 skjnldsv

@ShGKme You might have accidentally committed a dev build :D

st3iny avatar Oct 24 '23 07:10 st3iny

Not ready for review?

@ShGKme You might have accidentally committed a dev build :D

It was in draft waiting for the base branch https://github.com/nextcloud/server/pull/41063 to be merged.

Rebased now and ready for review.

ShGKme avatar Oct 24 '23 08:10 ShGKme