Grigorii K. Shartsev

Results 583 comments of Grigorii K. Shartsev

In Vue it breaks rendering and reactivity. In Vue-Router it makes app and lib using different injection symbol

Radio button is a bit too close to the radio check, IMO. ![Image](https://github.com/user-attachments/assets/b5073364-a6d4-4a92-a0dd-e1bc9865ab0d) What about this one instead? With less padding. ![Image](https://github.com/user-attachments/assets/d4d940d9-3078-4ade-a736-f98afcebe555) https://pictogrammers.com/library/mdi/icon/circle-slice-8/ Or even this? ![Image](https://github.com/user-attachments/assets/d39905cc-bacb-4454-93d0-300ee9c55b14) https://pictogrammers.com/library/mdi/icon/record-rec/

Cannot reproduce in docs. Checking in Polls.

I cannot reproduce in Polls (`master`). ![Image](https://github.com/user-attachments/assets/5acb336e-58b2-42fc-a3cc-307e0b9ab907)

Component requires confirmation only with `confirm` prop. See "Example with confirm button". You need to add `confirm: true`. https://nextcloud-vue-components.netlify.app/#/Components/NcPickers?id=ncdatetimepicker

> Is this new? I'm not sure, but it is the same in v8...

Workaround: ```sh flatpak override --user --filesystem=/tmp:ro com.nextcloud.talk ```

> > here `NcUserBubble` is used as a clickable `div` > > Without additional context (spreed PR), clickable div itself should be already an issue. Maybe we should extend it...

The problem is that it is not reexported in `components/index.ts`. A workaround that might work for you: ```ts InstanceType['$props']['variant'] ```

> I wanted to import `ButtonType` If you actually mean `ButtonType`, and not `ButtonVariant`, you can use: ```ts ButtonHTMLAttributes['type'] ``` It's a built-in type (lib/DOM).