nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

fix(NcUserBubble): indicate that element is clickable

Open Antreesy opened this issue 1 year ago • 2 comments

☑️ Resolves

  • Show interactive cursor pointer if an element has click event or a content to show in Popover

RFC:

Isn't &--clickable * too wide? I doubt anyone is planning to insert an input in name slot, but still

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • [ ] ⛑️ Tests are included or are not applicable
  • [x] 📘 Component documentation has been extended, updated or is not applicable
  • [ ] 3️⃣ Backport to next requested with a Vue 3 upgrade

Antreesy avatar Jun 14 '24 13:06 Antreesy

here NcUserBubble is used as a clickable div

Without additional context (spreed PR), clickable div itself should be already an issue. Maybe we should extend it to <a>/<button>/<div> at least?

Antreesy avatar Jun 14 '24 14:06 Antreesy

here NcUserBubble is used as a clickable div

Without additional context (spreed PR), clickable div itself should be already an issue. Maybe we should extend it to <a>/<button>/<div> at least?

Component already supports <a> with href prop. We can also add to prop to support <RouterLink>.

With Popover it is still clickable <div>, but let's call it a separate issue

ShGKme avatar Jun 14 '24 16:06 ShGKme

/backport to next

Antreesy avatar Aug 05 '24 08:08 Antreesy