nextcloud-vue icon indicating copy to clipboard operation
nextcloud-vue copied to clipboard

[9.0.0-alpha] - NcDateTimePicker behaves different

Open dartcafe opened this issue 1 year ago • 1 comments

Previously I could select a date and confirm the choice with an OK button. The 9.0.0-alpha.5 variant closes the popup upon clicking on a date.

Version 8Version 9

https://github.com/user-attachments/assets/6c621259-90ff-46c4-9da8-5f8c422a1723

https://github.com/user-attachments/assets/eff3291a-57d3-43b0-bfa6-61d86a670492

IMHO it should behave like before

dartcafe avatar Aug 10 '24 14:08 dartcafe

Yes I also agree, this is a bug.

susnux avatar Aug 14 '24 17:08 susnux

@susnux Any change to fix that for the next release (alpha-6)? It still breaks the UX of Polls significantly.

dartcafe avatar Jan 17 '25 07:01 dartcafe

Cannot reproduce in docs. Checking in Polls.

ShGKme avatar Jan 25 '25 18:01 ShGKme

I cannot reproduce in Polls (master).

Image

ShGKme avatar Jan 26 '25 10:01 ShGKme

In master you find the current main branch with vue2. next is the vue3 branch: https://github.com/nextcloud/polls/tree/next

dartcafe avatar Jan 26 '25 12:01 dartcafe

Component requires confirmation only with confirm prop.

See "Example with confirm button". You need to add confirm: true.

https://nextcloud-vue-components.netlify.app/#/Components/NcPickers?id=ncdatetimepicker

ShGKme avatar Jan 26 '25 16:01 ShGKme

OMFG. Are you kidding???? 🤣

Is this new? I did not recognize any change regarding this setting. Anyway. Thanks for the help, this seems to work now. Now I have to find out, why the time span is not created properly.

dartcafe avatar Jan 27 '25 11:01 dartcafe

Is this new?

I'm not sure, but it is the same in v8...

ShGKme avatar Jan 27 '25 20:01 ShGKme

Yes, True. And now I know, why I did not use it. I don't get proper information about the modelValue while picking dates, but I need it to be able to display the preview of the result.

Anyway, the behavior is still strange without confirmation: true. I get the values in a wrong order, but could not debug it deep enough. And there is the OK button, I don't need.

dartcafe avatar Feb 01 '25 12:02 dartcafe