Sean DuBois

Results 605 comments of Sean DuBois

Hey @salrashid123 could I get your help on this? I am going to start working on a new major release and want to address all API breaks. Do you have...

Fantastic, thank you so much @0x34d Can you fix the golangci-lint errors? If you don't feel comfortable doing it I can help!

@0x34d you are in the org now so you can run yourself :) sorry for slowing you down

I added a test, after CI passes will merge!

Hopefully you got this work @lhd2001! If you are still having problems we are here to help, thanks for using Pion :)

Agree on NALU API being awkward! do you have bandwidth to update H264 depacketizer I can test + approve? We should make that change ASAP before people depend on it....

@aler9 I think the best way to do this is the Option pattern we use in Pion. You can see it in [GeneratorOption](https://github.com/pion/interceptor/blob/master/pkg/nack/generator_option.go) there is also a ResponderOption in the...

Thank you so much @jech. I am going to move forward with everything until the TWCC. I am hoping I can make things good enough that you can simplify Galene....

@aler9 We couldn't not even worry about REMB if that makes things simpler! Looking at Chromium's RTCP parser I don't think they care. Mostly in [rtcp_receiver.cc](https://webrtc.googlesource.com/src/+/refs/heads/master/modules/rtp_rtcp/source/rtcp_receiver.cc#1046) We should start with...

@dtaht I had no idea DSCP/ECN would be needed. That is going to be somewhat of a pain because our [ICE Agent](https://github.com/pion/ice) only deals in bytes. Putting audio/video on different...