Sean DuBois
Sean DuBois
Great find @sirzooro! I think we need to keep the goroutine, but deliver the events in order. If we drop the goroutine the user can block our main thread. Maybe...
If you are interested in implementing this I would love to work with you on it!
great! Totally agree with that. Could you write a test that blocks the callback with something long running? Just to confirm we aren't introducing a behavior change?
@dirkx Sounds good to me! Mind making a PR?
@streamer45 trivial! I would follow the same pattern as mDNS. When you get a hostname attempt to resolve it a thread, and then add it on success. [here is mDNS](https://github.com/pion/ice/blob/master/agent.go#L668-L681)
Oh yes! This is just for the client side. That *might* just work today with NAT1To1 in the SettingEngine. What happens if you do that today?
Cherry-picked as 970978e8c79a2d68234ff1e85b655dbde0b090c9 thank you @dirkx Just had to fix a typo in the comment to pass CI
This is fantastic @stv0g very cool. we can implement stuff like PCP/NAT-PMP. Keep it nice and decoupled. This is gonna be a really fun write up! It would be nice...
Hey @stv0g I am still in support of this! I think it would be great to move everything into `pion/portmap` and support lots of other methods of gathering. For now...
Sorry I didn't follow up on this earlier :/ Fixed with https://github.com/pion/turn/commit/5484f25e4c38729930ed8dc20f3e46a383f09fb5