Sean DuBois

Results 605 comments of Sean DuBois

cherry picked assert -> require 05ab6847411265463a1852a0de4d597f1d9d99bc

Cherry picked CheckRoutines simplification in 01c35354b07b10903f3dfac64c883356958241a7

Cherry picked test.TimeOut change with 85a3a7f52407586fea6957187c461aaa08241611

Cherry-picked `t.Fatal` -> `require.NoError` with 52f2075c2e91a4912adcf4a7a13cdf019fbd5bd6

Sorry this didn't get a response sooner. I spent a lot of time prototyping/trying different things here. I think if someone doesn't want ICE using ORTC is a better bet....

IPv6 support was added with 39c0392295a06b5cac940f7a49d61cc74ca56c6f thank you @edaniels !

@m1k1o It looks like `candidateConn` is nil? https://github.com/pion/ice/blob/master/agent.go#L817C1-L818C1 I think it would be worth adding a defensive `if candidateConn != nil` check It would be nice to figure out why...

That is a strange one! I think we might be able to reproduce this though. Can you create a TCP client that doesn't disconnect properly. Maybe as simple as connecting...

Closing, no work to be done here!

Cherry-picked with 77cc354d7ff64da809e1b2b36b27ff443f7415ef