dtls icon indicating copy to clipboard operation
dtls copied to clipboard

flight3: respect curves configuration

Open Snawoot opened this issue 2 years ago • 1 comments

Description

As far as I understand Flight3 is pretty much like Flight1, but with Cookie. So I just reuse logic from Flight1 to ensure correct behaviour.

Reference issue

Fixes #587

Snawoot avatar Sep 30 '23 21:09 Snawoot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.13%. Comparing base (61b3466) to head (8bf6f8c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #588      +/-   ##
==========================================
+ Coverage   80.07%   80.13%   +0.05%     
==========================================
  Files         101      101              
  Lines        5330     5330              
==========================================
+ Hits         4268     4271       +3     
+ Misses        687      684       -3     
  Partials      375      375              
Flag Coverage Δ
go 80.16% <100.00%> (+0.05%) :arrow_up:
wasm 63.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 01 '23 11:10 codecov[bot]

Seems related to https://github.com/pion/dtls/pull/475 (@daenney FYI)

@Snawoot Could you add a test as well as flight1?

at-wat avatar May 13 '24 01:05 at-wat

I added a test, after CI passes will merge!

Sean-Der avatar Jun 12 '24 18:06 Sean-Der