Scott Todd
Scott Todd
> > Currently byo_llvm is failing because llvm isn't being built with any of the PDLL libraries. I think this can be fixed by adding `mlir-pdll` to `LLVM_MLIR_TOOLS` in the...
Looks like this was fixed by https://github.com/iree-org/iree/pull/17299
> Maybe if you're fine with repeating values you could also just run smaller matmuls? +1. Can you change the sizes you are testing or shard the tests across multiple...
`--max_elements_to_check=0` does what you suggest I think? https://github.com/iree-org/iree/blob/8ae8aafb827419ce261ba43af5d9b1277049e3cb/tools/testing/e2e/test_utils.c#L40-L47
> @jinchen62 For these kinds of tests, i.e., polynomial approximations, you should keep a threshold. It won't match the entire precision. 1.101 and 1.10125 are close, given that it's an...
Please keep issues open until fixes have fully landed (https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue on the PR that fixes the issue helps automate that)
https://github.com/iree-org/iree/pull/17324 was merged with test failures (newly passing tests need XFAIL lists updated) so it was reverted in https://github.com/iree-org/iree/pull/17324. You may also want to update tolerances as discussed.
> was a compatibility-breaking change to this op. The MLIR bytecode format version was not bumped That's expected. The bytecode format version is not tied to any particular dialect, and...
I tried to regenerate the .mlirbc files for https://github.com/nod-ai/SHARK-TestSuite/tree/main/iree_tests/pytorch/models/resnet50 and https://github.com/nod-ai/SHARK-TestSuite/tree/main/iree_tests/pytorch/models/opt-125M, but hit issues with both. Need to apply more rigor to those frontend workflows. * resnet50 crashed in the...
Looking through the history of https://github.com/iree-org/iree/commits/main/build_tools/python/e2e_test_framework/models/matmul.py, I can't tell how to regenerate those matmul test files. Quite a few PRs with completely empty descriptions :/ Possibly https://github.com/iree-org/iree-experimental/tree/main/iree-torch/library, https://github.com/iree-org/iree-experimental/tree/main/iree-jax/library, etc.? We...