Sarah French
Sarah French
Just rebased on main because this PR's branch was pretty old. Before the rebase this test failure showed how the permadiff occurs : https://github.com/GoogleCloudPlatform/magic-modules/pull/10313#issuecomment-2025212589
That last test is failing due to a networking reason: ``` vcr_utils.go:152: Step 1/2 error: Error running apply: exit status 1 Error: Error waiting to create Connector: Error waiting for...
As a recap of this PR's stages: 1. Originally contained only an acceptance test demonstrating the permadiff in the linked issue [f7bce51](https://github.com/GoogleCloudPlatform/magic-modules/pull/10313/commits/f7bce5173bc377313e518d2a693d6c6987924856) - [test failure due to permadiff here](https://github.com/GoogleCloudPlatform/magic-modules/pull/10313#issuecomment-2025212589) 2....
In the commits above I stop users from being able to include both min_throughput and min_instance (same for max_) by making fields conflict. Previously users would experience a permadiff, but...
Ah, we cannot have acc tests that don't reach out to an API run in VCR: ``` test_utils.go:108: no cassette found on disk for TestAccVPCAccessConnector_vpcAccessConnectorThroughput_combiningThroughputAndInstancesFields_conflict, please replay this testcase in...
Tests pass when I run them with TF_ACC=1 locally, merging. Thanks for the review John!
Marked this as forward/exempt due to it being a networking issue in the test project
Looks like it could be an issue with sweeping up dangling resources, but would need to double-check the test's config and debug logs from the test
The test has passed over the past 3 days but I'd like to wait another day or two to check the flakiness is definitely gone: ![Screenshot 2024-06-17 at 12 19...
I can see that `TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample` passed last night 🎉 The `TestAccFirestoreDatabase_firestoreCmekDatabaseExample` test was previously affected by the "This project is not eligible..." error, which is now solved, but now it...