Sarah French
Sarah French
I've just merged https://github.com/GoogleCloudPlatform/magic-modules/pull/10823 which should allow users to create new google_compute_security_policy resources where adaptive_protection_config.layer_7_ddos_defense_config is explicitly disabled: ``` adaptive_protection_config { layer_7_ddos_defense_config { enable = false } } ``` That...
The panic has only happened twice, and the test has passed between both panics so it might be due to the contents of the API responses?
I'm going to update the issue description with a list of data sources that have been migrated to the plugin framework, and acceptance tests including those data sources are likely...
I'm not free enough to do a deep-dive on this issue, but it occurred to me that a bunch of acceptance tests for the plugin-framework migrated data sources include tests...
From what I've seen in https://github.com/GoogleCloudPlatform/magic-modules/pull/9742#issuecomment-1876041100 when implementing a new data source using the plugin-framework I'm more convinced that there is a VCR issue that's related to the plugin-framework, and...
# Investigation ## Stuff from running TestAccDataSourceDnsManagedZone_basic in VCR_MODE=RECORDING locally The test passes, there are files made but they're 'incomplete': `fixtures/TestAccDataSourceDnsManagedZone_basic.seed` ``` 2815386111364297813 ``` `fixtures/TestAccDataSourceDnsManagedZone_basic.yaml` ``` --- version: 1 interactions:...
More notes: - The act of stopping (via `.Stop()`) the recorder in the provider client causes the API interactions to be saved to YAML files by the package we use...
In addition to what I said before, there is another incompatibility between VCR and the PF-implemented data source: When performing Read actions (no C/U/D on data source) a [new client...
I'm currently writing up an RFC that includes discussion about this issue and possible solutions. While I was taking a look in the code I noticed that the SDK provider...
Update: I've been working on fixing issues with the muxing in the Google provider(s) and those changes fix the issue with VCR tests. I won't close this issue until those...